-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
share system certificate support #2653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This is already installed |
VietND96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thank you, @ritzk! |
|
To use this, mount the root ca to /usr/local/share/ca-certificates/my-ca-dir using extraVolumeMounts/extraVolumes, and setup postStart command: ["/bin/bash", "-c", "sudo ln -sf /usr/lib/x86_64-linux-gnu/pkcs11/p11-kit-trust.so /usr/lib/x86_64-linux-gnu/libnssckbi.so"]ref: #1176 |
User description
Description
support shared system certificate
Motivation and Context
This will allow one drop ca certs to /usr/local/share/ca-certificates via volumes/mount, run update-ca-certificates as a part of postStart, and test against sites secured by self-signed certificates.
Types of changes
Checklist
notes:
https://manpages.debian.org/buster/ca-certificates/update-ca-certificates.8.en.html
https://github.com/chromium/chromium/blob/main/docs/linux/cert_management.md
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704180
PR Type
Enhancement
Description
Added support for shared system certificates in Dockerfile.
Installed
p11-kitandp11-kit-modulesfor certificate management.Facilitates testing against self-signed certificate-secured sites.
Changes walkthrough 📝
Dockerfile
Add shared system certificate support in DockerfileNodeBase/Dockerfile
p11-kitandp11-kit-modulespackages.